Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-grained visibility of analyses in results reports and client views #241

Merged
merged 2 commits into from
Sep 1, 2017

Conversation

xispa
Copy link
Member

@xispa xispa commented Sep 1, 2017

The default visibility of a given analysis in result reports (or when the current user is a Client Contact) can be established beforehand by making use of an Analysis Profile or an Analysis Template. Another option is to define their visibility once created, at Analysis Request level, in Manage Analyses tab. As part of the Reflex Testing functionality, one can create automated rules that, amongst other actions, can generate duplicates, retests, etc. Because of this behavior, an Analysis Request will usually end up containing more than one analysis of the same type (Analysis Service). Therefore, the assignment of visibility with the above mentioned tools, which use Analysis Services instead of analyses, is clearly not enough: labman must be able to choose which intermediate or final results generated due to the actions triggered within a reflex rule process have to be displayed in results report or accessible to client, regardless of their "type".

With this Pull Request, a checkbox is displayed in the Analyses list from inside Analysis Request, so the user with "Add Analyses" privileges (typically labman) will be able to set the visibility at analysis level. By default, the visibility assigned to a given analysis is determined by the mechanisms that are already in place (Analysis Service visibility at Analysis Request, Analysis Profile and Analysis Template levels). When the visibility is set at analysis level, this setting prevails over the rest of criteria. The visibility can be set also if the analysis has been verified or published already, cause this setting does not affect the results and is mainly for presentation purposes.

hidden

@nihadness nihadness merged commit 17319e3 into wip Sep 1, 2017
@xispa xispa deleted the analyses-report-visibility branch September 1, 2017 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants