Fine-grained visibility of analyses in results reports and client views #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default visibility of a given analysis in result reports (or when the current user is a Client Contact) can be established beforehand by making use of an Analysis Profile or an Analysis Template. Another option is to define their visibility once created, at Analysis Request level, in Manage Analyses tab. As part of the Reflex Testing functionality, one can create automated rules that, amongst other actions, can generate duplicates, retests, etc. Because of this behavior, an Analysis Request will usually end up containing more than one analysis of the same type (Analysis Service). Therefore, the assignment of visibility with the above mentioned tools, which use Analysis Services instead of analyses, is clearly not enough: labman must be able to choose which intermediate or final results generated due to the actions triggered within a reflex rule process have to be displayed in results report or accessible to client, regardless of their "type".
With this Pull Request, a checkbox is displayed in the Analyses list from inside Analysis Request, so the user with "Add Analyses" privileges (typically labman) will be able to set the visibility at analysis level. By default, the visibility assigned to a given analysis is determined by the mechanisms that are already in place (Analysis Service visibility at Analysis Request, Analysis Profile and Analysis Template levels). When the visibility is set at analysis level, this setting prevails over the rest of criteria. The visibility can be set also if the analysis has been verified or published already, cause this setting does not affect the results and is mainly for presentation purposes.