Visibility of automatically created analyses because of reflex rules actions #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Sep 1, 2017
| return DisplayList([ | ||
| ('default', 'Visibility (default)'), | ||
| ('visible', 'Show in Report'), | ||
| ('invisible', 'Hide In Report')]) |
There was a problem hiding this comment.
should be:
return DisplayList([
('default', _('Visibility (default)')),
('visible', _('Show in Report'))),
('invisible', _('Hide In Report')))])Otherwise, these strings will never appear translated.
| @@ -427,7 +435,17 @@ def getActionVoc(self): | |||
| return DisplayList([ | |||
| ('repeat', 'Repeat'), | |||
| ('duplicate', 'Duplicate'), | |||
| ('setresult', 'Set result')]) | |||
| ('setresult', 'Set result'), | |||
| ('setvisibility', 'Set Visibility')]) | |||
There was a problem hiding this comment.
return DisplayList([
('repeat', _('Repeat')),
('duplicate', _('Duplicate')),
('setresult', _('Set result')),
('setvisibility', _('Set Visibility'))])
xispa
changed the title
xispa
changed the title
xispa
changed the title
xispa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all analyses of AR are visible/invisible in final report depending of their Default AS settings. In some cases it is not necessary to show original (base) analysis or other duplicated analyses which don't contain final result. This pull request aims to let users define visibility of duplicated/repeated analyses in Reflex Rule level. However, it is possible to update that value from 'Manage Results' view with enough privileges. For more information about visibility settings of analyses, please see #241 .
With this Pull Request new action- 'Set visibility', will be added to the actions list of Reflex Rules. Moreover, for 'Repeat' and 'Duplicate' actions (which they create new analysis) there will be new select field as well to show or hide new analysis.
In the attached image you can see a simple example of this new feature.