Unpublished filter for AR listing view and display according to the setup #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
approved these changes
Feb 16, 2018
| self.contentFilter = { | ||
| "sort_on": "created", | ||
| "sort_order": "descending", | ||
| "path": {"query": "/", "depth": 2}, |
There was a problem hiding this comment.
Not important, but path is not required, cause the catalog to search against only contains objects from AnalysisRequest portal type. Also, self.contentFilter is overrided in derived classes like client.analysisrequests and path is correctly set there:
so they wouldn't be affected
| # remove `rejected` filter | ||
| if not setup.getRejectionReasons(): | ||
| self.review_states = filter( | ||
| lambda x: x.get("id") != "rejected", self.review_states) |
There was a problem hiding this comment.
Thanks for removing these filters, but remember this should be done in a separate PR :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR introduces an "unpublished" filter button for the AR listing view.
Furthermore, it displays filter buttons according to the setup (see: #575)
Current behavior before PR
Desired behavior after PR is merged
-Possible to filter unpublished ARs
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.