Traceback when submitting duplicate when Duplicate Variation is not set #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Traceback when submitting duplicate when Duplicate Variation is not set.
With this Pull Request, default value 0.0 is assigned for Duplicate Variation field. Also, an upgrade step that updates all non-floatable Duplicate Variation values for both Analysis Services and Analyses
Linked issue: #768
Current behavior before PR
When creating Analysis Service, no default value is set for field "DuplicateVariation". This causes a traceback later, when submitting results for corresponding duplicate analyses.
Desired behavior after PR is merged
Not traceback appear when submitting duplicates and Analysis Services have default value for "Duplicate Variation" field set to 0.0 after creation.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.