Traceback when submitting duplicate when Duplicate Variation is not set

CHANGES.rst

@@ -12,10 +12,8 @@ Changelog
 
 **Removed**
 
-
-**Fixed**
-
--  #771 Slow Searches in Listing Views
+- #769 Traceback when submitting duplicate when Duplicate Variation is not set
+- #771 Slow Searches in Listing Views
 - #774 When retracting an Analysis Requests its analyses are also retracted
 - #772 Improved UID check in API
 

bika/lims/content/abstractbaseanalysis.py

@@ -351,6 +351,7 @@
 # The amount of difference allowed between this analysis, and any duplicates.
 DuplicateVariation = FixedPointField(
     'DuplicateVariation',
+    default='0.00',
     schemata="Method",
     widget=DecimalWidget(
         label=_("Duplicate Variation %"),

bika/lims/upgrade/v01_02_005.py

@@ -29,9 +29,42 @@ def upgrade(tool):
     logger.info("Upgrading {0}: {1} -> {2}".format(product, ver_from, version))
 
     # -------- ADD YOUR STUFF HERE --------
+
+    # Traceback when submitting duplicate when Duplicate Variation is not set
+    # Walkthrough all analyses and analyses services and set 0.00 value for
+    # DuplicateVariation if returns None
+    # https://github.com/senaite/senaite.core/issues/768
+    fix_duplicate_variation_nonfloatable_values()
+
     ut.addIndex(CATALOG_ANALYSIS_REQUEST_LISTING, "listing_searchable_text",
                 "TextIndexNG3")
     ut.refreshCatalogs()
     logger.info("{0} upgraded to version {1}".format(product, version))
 
     return True
+
+def fix_duplicate_variation_nonfloatable_values():
+    # Update Analysis Services
+    catalog = api.get_tool('bika_setup_catalog')
+    brains = catalog(portal_type='AnalysisService')
+    for brain in brains:
+        service = api.get_object(brain)
+        dup_var = service.getDuplicateVariation()
+        if api.is_floatable(dup_var):
+            continue
+        service.setDuplicateVariation(0.0)
+        logger.info("Updated Duplicate Variation for Service '%s': '0.0'" % (
+                    service.Title()))
+
+    # Update Analyses
+    catalog = api.get_tool('bika_analysis_catalog')
+    portal_types = ['Analysis', 'ReferenceAnalysis', 'DuplicateAnalysis']
+    brains = catalog(portal_type=portal_types)
+    for brain in brains:
+        analysis = api.get_object(brain)
+        dup_var = analysis.getDuplicateVariation()
+        if api.is_floatable(dup_var):
+            continue
+        analysis.setDuplicateVariation(0.0)
+        logger.info("Updated Duplicate Variation for Analysis '%s': '0.0'" % (
+                    analysis.Title()))