Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when Saving AR results #813

Merged
merged 2 commits into from
May 5, 2018
Merged

TypeError when Saving AR results #813

merged 2 commits into from
May 5, 2018

Conversation

xispa
Copy link
Member

@xispa xispa commented May 3, 2018

Description of the issue/feature this PR addresses

In some instances (maybe with outdated dependencies?), the exception TypeError: can only compare to a set (see below) is thrown when the a set type is used instead of list on catalog searches.

Linked issue: #812

Current behavior before PR

Traceback (innermost last):
Module ZPublisher.Publish, line 138, in publish
Module ZPublisher.mapply, line 77, in mapply
Module ZPublisher.Publish, line 48, in call_object
Module bika.lims.browser.analysisrequest.workflow, line 64, in _call_
Module bika.lims.browser.analysisrequest.workflow, line 342, in workflow_action_submit
Module bika.lims.browser.analyses.workflow, line 219, in workflow_action_submit
Module bika.lims.api, line 655, in search
Module Products.CMFPlone.CatalogTool, line 389, in searchResults
Module Products.ZCatalog.ZCatalog, line 604, in searchResults
Module Products.ZCatalog.Catalog, line 925, in searchResults
Module Products.ZCatalog.Catalog, line 545, in search
Module Products.PluginIndexes.common.UnIndex, line 403, in _apply_index
TypeError: can only compare to a set

Desired behavior after PR is merged

Search is performed correctly without complains

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jordi!

@ramonski ramonski merged commit ac23458 into master May 5, 2018
@ramonski ramonski deleted the i812 branch May 20, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants