Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when Saving AR results #813

Merged
merged 2 commits into from
May 5, 2018
Merged

TypeError when Saving AR results #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97074c9
TypeError when Saving AR results
xispa May 3, 2018
a29917f
Merge branch 'master' into i812
ramonski May 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ Changelog


**Fixed**


- #813 Saving AR results gives TypeError: can only compare to a set
- #799 On AR Listing, inline edit for Date Sampled not working when Sampler has a value
- #776 Analyses submission in Worksheet is slow
- #726 404 Error raised when clicking Print Samples Sheets from within a client
Expand Down
4 changes: 2 additions & 2 deletions bika/lims/browser/analyses/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def workflow_action_submit(self):
# AR Catalog contains some metadata that that rely on the Analyses an
# Analysis Request contains.
if affected_ars:
query = dict(UID=affected_ars, portal_type="AnalysisRequest")
query = dict(UID=list(affected_ars), portal_type="AnalysisRequest")
for ar_brain in api.search(query, CATALOG_ANALYSIS_REQUEST_LISTING):
if ar_brain.review_state == 'to_be_verified':
continue
Expand All @@ -226,7 +226,7 @@ def workflow_action_submit(self):
ar.reindexObject()

if affected_ws:
query = dict(UID=affected_ws, portal_type="Worksheet")
query = dict(UID=list(affected_ws), portal_type="Worksheet")
for ws_brain in api.search(query, CATALOG_WORKSHEET_LISTING):
if ws_brain.review_state == 'to_be_verified':
continue
Expand Down