-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "whole word" search option #1229
Add "whole word" search option #1229
Conversation
…rformant now too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work overall, but a couple issues noted in the comments. In particular the regex one needs to change. I didn't have time to do a thorough review, so it's possible that my comments on scrollDivToId
aren't correct and the error-checking isn't necessary.
Once the search is regex-character-safe, I'll be ready to approve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now that the regex-escaping code is in. I noticed one bit of end-of-line whitespace (which GitHub's highlighting flagged as I was reviewing the commit, or I would have missed it). That's just cosmetic, though, and even if that doesn't get fixed this PR is good to go.
Description
This feature will allow users to perform "whole word" searches. There are a bunch of ways to test this, please let me know if you'd like me to add any more tests below.
Fixes #1222
Type of Change
Screenshots
Provided with test cases below
How Has This Been Tested?
Project used for testing (5491 entries): Alex's project.zip
Functional testing (should work the same in both list and entry view)
sor
orSOR
should result in 47 matchessort
orSORT
should result in 4 matchesScreen.Recording.2021-10-25.at.3.34.24.PM.mov
Screen.Recording.2021-10-25.at.3.41.58.PM.mov
Viewport testing (list view)
2.1.2
should result in 2 matches[a-z]
should result in 0 matchesViewport testing (entry view)
Checklist: