fix(provider): split task.RunCommand into RunCommand and RunCommandWhileStopped #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zygimantass
requested review from
davidterpay,
nivasan1,
aljo242 and
Eric-Warehime
as code owners
aljo242
reviewed
Jan 26, 2024
| @@ -224,6 +225,43 @@ func (p *Provider) RunCommand(ctx context.Context, id string, command []string) | |||
| return stdout.String(), stderr.String(), execInspect.ExitCode, nil | |||
| } | |||
|
|
|||
| func (p *Provider) RunCommandWhileStopped(ctx context.Context, id string, definition provider.TaskDefinition, command []string) (string, string, int, error) { | |||
There was a problem hiding this comment.
It's generally better to return structs, or name the return variables when they go above like 2 or 3.
I would do one of those. Otherwise it can be confusing to reason what is being returned from this func.
Godoc comment would help too
feat(provider): add DigitalOcean provider
fix(provider): allow providers to choose how they parse ports
fix(provider): use task ID instead of volume name for interacting with files
feat(node): add NodeDefinitionModifier
feat(provider): add provider specific configuration
|
@Mergifyio backport release/v2.x.x |
❌ No backport have been created
Git reported the following error: |
Zygimantass
added a commit
that referenced
this pull request
Jan 30, 2024
fix(provider): split task.RunCommand into RunCommand and RunCommandWhileStopped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.