Hook beforeunload to cancel existing requests #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing passkeys on desktop Safari getting progressively less reliable, as noted in this bug. My hunch is that there's some sort of browser-wide state getting thrown off if requests (in practice, only conditional) hang around.
To be clear, I'm not sure if this will actually work. I haven't witnessed it causing any issues, and it seemed to minorly improve the situation (but the system in question is completely opaque to me, so it's just as likely coincidental) - after testing locally, Safari seemed to be not completely stuck after a couple cycles through. Other than a handful of additional bytes, I don't see much of a downside here.