[smartswitch] Add HLD for IP address assignment in Smart Switch. #1504
Conversation
oleksandrivantsiv
commented
Oct 26, 2023
•
oleksandrivantsiv
commented
| PR title | State | Status | Dependencies | Unitest | Owner |
|---|---|---|---|---|---|
| [yang][smartswitch] Add YANG model for MID_PLANE_BRIDGE and DPU tables. |  |
checkers passed | N/A | added | @oleksandrivantsiv |
| [smartswitch] Add support of a new 't1-smartswitch' topology to the sample config generator. |  |
checkers in-progress | PR #17311 | added | @oleksandrivantsiv |
|
hi Oleksandr, do you mind to move the files from dash folder to "smart-switch" folder? the dash folder is mostly only focus on the dash object model that used by our northbound interface. and everything else related to smart switch will be better to put under smart-switch folder, e.g., HA design. |
| "DEVICE_METADATA": { | ||
| "localhost": { | ||
| "switch_type": "switch", | ||
| "type": "SmartSwitch", |
There was a problem hiding this comment.
This must be subtype. type is used as "LeafRouter" etc. Please update Yang as well.
| "GLOBAL": { | ||
| "bridge" : "bridge_midplane", | ||
| "address": "169.254.200.254/24", | ||
| "members": ["Dpu0", "Dpu1"] |
There was a problem hiding this comment.
No, we can get the information from the DPUS table. Removed
| 2. Extend existing YANG model tests to cover MGMT_INTERFACE table changes. | ||
| 3. Add new tests to cover the handling of MID_PLANE_BRIDGE and DPUS tables in sonic-cfggen utility. | ||
| 4. Add new tests to cover DHCP server configuration generation for the Smart Switch in sonic-cfggen utility. | ||
| 5. Extend interface-config.service tests to verify midplane bridge configuration generation. |
There was a problem hiding this comment.
I think we should have a test to ensure these midplane IPs are not advertised via BGP
Done |
|
@prsunny can we merge this PR? |
