[smartswitch] Add support of a new 't1-smartswitch' topology to the sample config generator. #17326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ample config generator.
dgsudharsan
approved these changes
Nov 29, 2023
Yakiv-Huryk
approved these changes
Nov 29, 2023
liat-grozovik
approved these changes
Dec 7, 2023
yaqiangz
reviewed
Dec 21, 2023
| data['MID_PLANE_BRIDGE'] = { | ||
| 'GLOBAL': { | ||
| 'bridge': bridge_name, | ||
| 'address': '{}/24'.format(mpbr_address) |
There was a problem hiding this comment.
@oleksandrivantsiv This field address is inconsistent with yang model https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-smart-switch.yang#L42. Should it be ip_prefix?
There was a problem hiding this comment.
@yaqiangz you are right. I'll create a PR with the fix.
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add support of a new 't1-smartswitch' topology to the sample config generator. The topology passed to sonic-cfggen utility as a parameter to generate sample configuration for Smart Switch:
Work item tracking
How I did it
Extend sample config generator to support new topology and read Smart Switch specific data from hwsku.json.
How to verify it
Run unit tests. The changes are covered with the new unit tests.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)