Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new topology for smartswitch #14797

Closed
wants to merge 3 commits into from

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Sep 30, 2024

Description of PR

Summary:
Fixes # (issue)
Microsoft ADO: 25068545

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Need new topology to support smartswitch testbed

How did you do it?

Add new topology and related testbed information

How did you verify/test it?

Run add-topo and deploy-mg, check device configuration

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@prsunny prsunny requested a review from prabhataravind October 8, 2024 17:51
@prabhataravind
Copy link
Contributor

@ganglyu can we rename this topo as t1-smartswitch? Please refer a related PR in sonic-net/sonic-buildimage#17326

@ganglyu
Copy link
Contributor Author

ganglyu commented Oct 8, 2024

@ganglyu can we rename this topo as t1-smartswitch? Please refer a related PR in sonic-net/sonic-buildimage#17326

I suggest using t1-8-lag-smartswitch, t1-32-lag-smartswitch, and t1-64-lag-smartswitch as topology names, please let me know what you think.

@r12f
Copy link
Contributor

r12f commented Oct 9, 2024

seems to be the same work that Jing is doing?

PR: #14595 (Please ignore the demo folder).

@@ -351,3 +351,20 @@
inv_name: veos_vtb
auto_recover: 'False'
comment: Tests virtual switch vm

- conf-name: vms-kvm-smartswitch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the topology update between NPU to DPU VMs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only created VM for NPU and DPU in this PR.
We will have another PR to cover the connection between NPU to DPU VMs.

@ganglyu
Copy link
Contributor Author

ganglyu commented Oct 9, 2024

seems to be the same work that Jing is doing?

PR: #14595 (Please ignore the demo folder).

Need to check with Jing

@ganglyu ganglyu marked this pull request as draft October 9, 2024 01:29
@ganglyu ganglyu closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants