Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hash] Update yang model with IPV6_FLOW_LABEL (for ECMP or LAG) #21522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ayurkiv-nvda
Copy link
Contributor

@ayurkiv-nvda ayurkiv-nvda commented Jan 24, 2025

Related PRs:
sonic-net/sonic-utilities#3730
sonic-net/sonic-sairedis#1508
sonic-net/sonic-swss#3481

Why I did it

Need to add SAI_NATIVE_HASH_FIELD_IPV6_FLOW_LABEL for hash calculation. Need to align Yang model.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Added IPV6_FLOW_LABEL to Generic Hash Yang model (both ecmp_hash and lag_hash). path: SWITCH_HASH/GLOBAL
Updated existing UT.
Updated Configuration.md

How to verify it

1)make configure PLATFORM=mellanox
2)make target/sonic-mellanox.bin
3)check model

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202411

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayurkiv-nvda ayurkiv-nvda force-pushed the master_add_ipv6_label_upstream branch from abf0caf to bdad4fa Compare January 29, 2025 14:43
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayurkiv-nvda ayurkiv-nvda force-pushed the master_add_ipv6_label_upstream branch from bdad4fa to 0592bba Compare February 3, 2025 14:25
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayurkiv-nvda ayurkiv-nvda marked this pull request as draft February 4, 2025 18:55
@ayurkiv-nvda ayurkiv-nvda force-pushed the master_add_ipv6_label_upstream branch from 0592bba to c2339a2 Compare February 4, 2025 18:58
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@wen587 wen587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -40,6 +40,7 @@ module sonic-hash {
enum INNER_SRC_IP;
enum INNER_L4_DST_PORT;
enum INNER_L4_SRC_PORT;
enum IPV6_FLOW_LABEL;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update unit test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayurkiv-nvda ayurkiv-nvda force-pushed the master_add_ipv6_label_upstream branch from e1218c3 to de22cdc Compare March 14, 2025 00:54
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayurkiv-nvda ayurkiv-nvda force-pushed the master_add_ipv6_label_upstream branch from de22cdc to c2a906e Compare March 15, 2025 14:48
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayurkiv-nvda ayurkiv-nvda force-pushed the master_add_ipv6_label_upstream branch from c2a906e to 314a8ee Compare March 15, 2025 15:01
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants