Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hash] update GH frontend with IPV6_FLOW_LABEL for ECMP/LAG switch hash configuration #3730

Merged
merged 1 commit into from
Mar 13, 2025
Merged

[hash] update GH frontend with IPV6_FLOW_LABEL for ECMP/LAG switch hash configuration #3730

merged 1 commit into from
Mar 13, 2025
+42 −19

Conversation

ayurkiv-nvda
Copy link
Contributor

What I did

CLI updated with ability to configure generic hash with IPV6_FLOW_LABEL parameter

How I did it

Updated HASH_FIELD_LIST
Updated sonic-utilities tests
Updated doc file

How to verify it

root@sonic:/home/admin# config switch-hash global ecmp-hash IPV6_FLOW_LABEL
root@sonic:/home/admin# config switch-hash global lag-hash IPV6_FLOW_LABEL
root@sonic:/home/admin# show switch-hash global
+--------+-----------------------------------+
| Hash   | Configuration                     |
+========+===================================+
| ECMP   | +-----------------+-------------+ |
|        | | Hash Field      | Algorithm   | |
|        | |-----------------+-------------| |
|        | | IPV6_FLOW_LABEL | CRC         | |
|        | +-----------------+-------------+ |
+--------+-----------------------------------+
| LAG    | +-----------------+-------------+ |
|        | | Hash Field      | Algorithm   | |
|        | |-----------------+-------------| |
|        | | IPV6_FLOW_LABEL | XOR         | |
|        | +-----------------+-------------+ |
+--------+-----------------------------------+

root@sonic:/home/admin# show switch-hash capabilities
+--------+-------------------------------------+
| Hash   | Capabilities                        |
+========+=====================================+
| ECMP   | +-------------------+-------------+ |
|        | | Hash Field        | Algorithm   | |
|        | |-------------------+-------------| |
|        | | SRC_IP            | CRC         | |
|        | | DST_IP            | XOR         | |
|        | | INNER_SRC_IP      | RANDOM      | |
|        | | INNER_DST_IP      | CRC_CCITT   | |
|        | | VLAN_ID           |             | |
|        | | IP_PROTOCOL       |             | |
|        | | ETHERTYPE         |             | |
|        | | L4_SRC_PORT       |             | |
|        | | L4_DST_PORT       |             | |
|        | | SRC_MAC           |             | |
|        | | DST_MAC           |             | |
|        | | IN_PORT           |             | |
|        | | INNER_IP_PROTOCOL |             | |
|        | | INNER_ETHERTYPE   |             | |
|        | | INNER_L4_SRC_PORT |             | |
|        | | INNER_L4_DST_PORT |             | |
|        | | INNER_SRC_MAC     |             | |
|        | | INNER_DST_MAC     |             | |
|        | | IPV6_FLOW_LABEL   |             | |
|        | +-------------------+-------------+ |
+--------+-------------------------------------+
| LAG    | +-------------------+-------------+ |
|        | | Hash Field        | Algorithm   | |
|        | |-------------------+-------------| |
|        | | SRC_IP            | CRC         | |
|        | | DST_IP            | XOR         | |
|        | | INNER_SRC_IP      | RANDOM      | |
|        | | INNER_DST_IP      | CRC_CCITT   | |
|        | | VLAN_ID           |             | |
|        | | IP_PROTOCOL       |             | |
|        | | ETHERTYPE         |             | |
|        | | L4_SRC_PORT       |             | |
|        | | L4_DST_PORT       |             | |
|        | | SRC_MAC           |             | |
|        | | DST_MAC           |             | |
|        | | IN_PORT           |             | |
|        | | INNER_IP_PROTOCOL |             | |
|        | | INNER_ETHERTYPE   |             | |
|        | | INNER_L4_SRC_PORT |             | |
|        | | INNER_L4_DST_PORT |             | |
|        | | INNER_SRC_MAC     |             | |
|        | | INNER_DST_MAC     |             | |
|        | | IPV6_FLOW_LABEL   |             | |
|        | +-------------------+-------------+ |
+--------+-------------------------------------+

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayurkiv-nvda ayurkiv-nvda mentioned this pull request Jan 24, 2025
Open
12 tasks
@ayurkiv-nvda ayurkiv-nvda force-pushed the master_ipv6_flow_label_upstream branch from f89c7dc to c189b86 Compare February 3, 2025 14:29
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayurkiv-nvda ayurkiv-nvda marked this pull request as draft February 4, 2025 18:55
@ayurkiv-nvda ayurkiv-nvda marked this pull request as ready for review February 10, 2025 19:17
@ayurkiv-nvda ayurkiv-nvda mentioned this pull request Feb 20, 2025
Merged
@stephenxs
Copy link
Collaborator

Hi @prsunny would you please merge this PR?

@liat-grozovik liat-grozovik merged commit 5e3b132 into sonic-net:master Mar 13, 2025
7 checks passed
@r12f
Copy link

r12f commented Mar 15, 2025

do we need this in 202412? @dgsudharsan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

@nazariig nazariig nazariig approved these changes

Assignees
No one assigned
Labels
Request for msft-202412 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ayurkiv-nvda @mssonicbld @stephenxs @r12f @prsunny @nazariig @dgsudharsan @liat-grozovik