Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VLAN][SW_MODE]: Switchport mode tests #17442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cshivashgit
Copy link

Tests have been added to verify interface mode configurations using "show interfaces switchport status" and "show interfaces status" commands

Fix is proposed through PR: sonic-net/sonic-utilities#3788

Description of PR

Summary: show interface state always show port as trunk port
Fixes # (issue)
Added new tests to verify interface's switchport status

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Interface mode change was not showing proper output in "show interfaces status"

How did you do it?

Found out the issue in intfutil.

"Vlan" column in "show interface status" is displayed based on below considerations:

  1. If interface is part of PortChannel - display PortChannel interface name [present behavior]
  2. If "switchport mode" is configured on interface [Ethernet/PortChannel] - display configured mode [new behavior]
  3. If "switchport mode" is NOT configured on interface but part of a VLAN [Ethernet/PortChannel] - display as "trunk" [present behavior]

How did you verify/test it?

Ran test on T0 setup.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Tests have been added to verify interface mode configurations using
"show interfaces switchport status" and "show interfaces status" commands
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@cshivashgit
Copy link
Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 17442 in repo sonic-net/sonic-mgmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants