Switchport mode update for 'show interfaces status' #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCA: According to present design port was conisdered as "trunk" if its part of a VLAN, there was no handling to fetch the acutal mode from Redis DB regarding the configured switchport mode. Solution: Configured "switchport mode" is fetched from DB for all front panel ports and PortChannel interfaces. "Vlan" column in "show interface status" is displayed based on below considerations: 1. If interface is part of PortChannel - display PortChannel interface name [present behavior] 2. If "switchport mode" is configured on interface [Ethernet/PortChannel] - display configured mode [new behavior] 3. If "switchport mode" is NOT configured on interface but part of a VLAN [Ethernet/PortChannel] - display as "trunk" [present behavior]
|
/azp run |
The committers listed above are authorized under a signed CLA. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@wen587 @xwjiang-ms please review |
| vlan_member_table = config_db.get_table('VLAN_MEMBER') | ||
|
|
||
| vlan_member_keys = [] | ||
| for _, key in vlan_member_table: |
There was a problem hiding this comment.
if vlan_member_table returned is dict, maybe it's better to use
vlan_member_keys = list(vlan_member_table.keys())
There was a problem hiding this comment.
@FengPan-Frank : Vlan Member table has two parts in the key - (VlanName, MemberInterfaceName) , in above code we are extracting the member interfaces , so using vlan_member_table.keys() will not give the same result
Sample VLAN_MEMBER table :
{('Vlan100', 'PortChannel100'): {'tagging_mode': 'untagged'}, ('Vlan100', 'Ethernet16'): {'tagging_mode': 'tagged'}}
FengPan-Frank
approved these changes
Mar 10, 2025
|
Could we add some ut for the new support? |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed "show interfaces status" output for interfaces with switchport mode configuration.
How I did it
Configured "switchport mode" is fetched from DB for all front panel ports and PortChannel interfaces.
"Vlan" column in "show interface status" is displayed based on below considerations:
How to verify it
Configure "switchport mode" for an interface/portchannel and verify the output in below show commands
Previous command output (if the output of a command-line utility has changed)
Previously it was always displaying as
trunkeven if interface is configured asaccessNew command output (if the output of a command-line utility has changed)
closes #3787