Merge pull request #58 from jhunkeler/iter-dynamic-xorder

Use local xorder instead of s->xorder
spacetelescope · Mar 6, 2025 · 21959be · 21959be
2 parents 38894a4 + 589bba5
commit 21959be
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -68,7 +68,7 @@ jobs:
       - run: python waf configure build
       - run: pip install "numpy==${{ matrix.numpy }}"
       - run: pip freeze
-      - run: pytest -rsv
+      - run: pytest -vvv -rs
   test_with_coverage:
     name: run tests with coverage
     needs: [ test ]
@@ -86,7 +86,7 @@ jobs:
       - run: python get_waf.py
       - run: python waf configure build
       - run: pip freeze
-      - run: pytest -rsv --cov=./ --cov-report=xml --cov-report term-missing
+      - run: pytest -vvv -rs --cov=./ --cov-report=xml --cov-report term-missing
       - uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3  # v5.3.1
         with:
           files: ./coverage.xml

diff --git a/.github/workflows/test_devdeps.yml b/.github/workflows/test_devdeps.yml
@@ -48,4 +48,4 @@ jobs:
       - run: python get_waf.py
       - run: python waf configure build
       - run: pip freeze
-      - run: pytest -rsv
+      - run: pytest -vvv -rs
diff --git a/src/surface/fit.c b/src/surface/fit.c
@@ -179,7 +179,7 @@ surface_fit_add_points(
 
         bxp = xbasis;
 
-        for (k = 1; k <= s->xorder; ++k) {
+        for (k = 1; k <= xorder; ++k) {
             for (i = 0; i < ncoord; ++i) {
                 bw[i] = byw[i] * bxp[i];
             }

diff --git a/test_c/test_c.py b/test_c/test_c.py
@@ -8,7 +8,7 @@
 ROOT = os.path.relpath(os.path.join('build', 'test_c'))
 TESTS = [
     'test_cholesky',
-    # 'test_geomap',  # FIXME: died with Signals.SIGABRT 6
+    'test_geomap',
     'test_lintransform',
     'test_surface',
     'test_triangles',