Use local xorder instead of s->xorder

[jhunkeler]

This addresses the >10 year old failure in test_geomap.

The local xorder variable is modified by a switch statement at the end of each yorder iteration, but the nested s->xorder loop never used xorder, so it would calculate a vindex that exceeded the upper bounds of the vzp array.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (05ae8ee) to head (589bba5).
Report is 5 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           1        1           
  Lines           7        7           
=======================================
  Hits            6        6           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mcara]

CC: @perrygreenfield - the only one who might know the IRAF code

[pllim]

[pllim]

Can we do a -vvv on the test log? I cannot see if the test really ran with just .....

Also makes me wonder about the remaining s->xorder usage all throughout that loop.

[mcara]

Also makes me wonder about the remaining s->xorder usage all throughout that loop.

like where?

[pllim]

stsci.stimage/src/surface/fit.c

Line 199 in 589bba5

assert((bbxp - xbasis) + ncoord - 1 < ncoord * s->xorder);

stsci.stimage/src/surface/fit.c

Line 214 in 589bba5

if ((int) (ll + s->xorder) > maxorder) {

[pllim]

Yay!

test_c/test_c.py::test_runall[build/test_c/test_geomap] PASSED           [ 36%]

[perrygreenfield]

LGTM

[jhunkeler]

Thank you^^

[pllim]

(I cannot merge but I want to!)

[mcara]

Risky but seems to work. Risky: because we still don't know what should be but it seems that not using xorder is causing buffer overruns

[mcara]

(I cannot merge but I want to!)

That is a safety feature

[pllim]

If you wanna be safer... https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches