Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code and documentation consistency #6918

Merged
merged 6 commits into from
Dec 26, 2024

Conversation

MarsonKotovi4
Copy link
Contributor

  • Fixed inconsistency in consume function naming
  • Improved comment accuracy (whenever -> whether)
  • Standardized path formatting in documentation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MarsonKotovi4)

@orizi orizi enabled auto-merge December 24, 2024 16:16
auto-merge was automatically disabled December 25, 2024 12:03

Head branch was pushed to by a user without write access

@MarsonKotovi4
Copy link
Contributor Author

@orizi fixed test

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MarsonKotovi4)

@orizi orizi enabled auto-merge December 25, 2024 12:36
auto-merge was automatically disabled December 26, 2024 20:01

Head branch was pushed to by a user without write access

@MarsonKotovi4
Copy link
Contributor Author

@orizi fixed test

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MarsonKotovi4)

@orizi orizi enabled auto-merge December 26, 2024 23:20
@orizi orizi added this pull request to the merge queue Dec 26, 2024
Merged via the queue into starkware-libs:main with commit 794953c Dec 26, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants