Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code and documentation consistency #6918

Merged
merged 6 commits into from
Dec 26, 2024
Merged

Improve code and documentation consistency #6918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b31b922
Update main.rs
MarsonKotovi4 Dec 24, 2024
b4185cf
Update readme.md
MarsonKotovi4 Dec 24, 2024
6a3e934
Update cancel_ops
MarsonKotovi4 Dec 24, 2024
37aeb0f
Update split_structs
MarsonKotovi4 Dec 25, 2024
3473f39
Merge pull request #1 from starkware-libs/main
MarsonKotovi4 Dec 26, 2024
c3db789
Update cancel_ops
MarsonKotovi4 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bin/get-lowering/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ struct Args {
#[arg(short, long)]
single_file: bool,

/// whenever to print all lowering stages or only the final lowering.
/// whether to print all lowering stages or only the final lowering.
#[arg(short, long)]
all: bool,

Expand Down
8 changes: 4 additions & 4 deletions crates/cairo-lang-lowering/src/optimizations/test_data/cancel_ops
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ fn foo(a: felt252) -> felt252 {
let (a, _arr) = c;
return a;
} else {
cosume(c);
consume(c);
return 1;
}
}
Expand All @@ -188,7 +188,7 @@ fn foo(a: felt252) -> felt252 {
foo

//! > module_code
extern fn cosume(arg: (felt252, Array<felt252>)) nopanic;
extern fn consume(arg: (felt252, Array<felt252>)) nopanic;

//! > semantic_diagnostics

Expand Down Expand Up @@ -242,7 +242,7 @@ End:

blk4:
Statements:
() <- test::cosume(v11)
() <- test::consume(v11)
(v28: core::felt252) <- 1
End:
Return(v28)
Expand Down Expand Up @@ -297,7 +297,7 @@ End:

blk4:
Statements:
() <- test::cosume(v11)
() <- test::consume(v11)
(v28: core::felt252) <- 1
End:
Return(v28)
Expand Down
8 changes: 4 additions & 4 deletions crates/cairo-lang-lowering/src/optimizations/test_data/split_structs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ fn foo(a: felt252) -> felt252 {
let (a, _arr) = c;
return a;
} else {
cosume(c);
consume(c);
return 1;
}
}
Expand All @@ -144,7 +144,7 @@ fn foo(a: felt252) -> felt252 {
foo

//! > module_code
extern fn cosume(arg: (felt252, Array<felt252>)) nopanic;
extern fn consume(arg: (felt252, Array<felt252>)) nopanic;

//! > semantic_diagnostics

Expand Down Expand Up @@ -198,7 +198,7 @@ End:

blk4:
Statements:
() <- test::cosume(v11)
() <- test::consume(v11)
(v28: core::felt252) <- 1
End:
Return(v28)
Expand Down Expand Up @@ -257,7 +257,7 @@ End:
blk4:
Statements:
(v31: (core::felt252, core::array::Array::<core::felt252>)) <- struct_construct(v0, v9)
() <- test::cosume(v31)
() <- test::consume(v31)
(v28: core::felt252) <- 1
End:
Return(v28)
Expand Down
4 changes: 2 additions & 2 deletions docs/reference/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ apt-get install asciidoctor
```

### Convert to HTML
> Tips:`pwd` is `cairo/docs/reference`
> Tip:`pwd` is `cairo/docs/reference`

- Convert a single file
```bash
Expand Down Expand Up @@ -51,7 +51,7 @@ apt-get install asciidoctor
```

### Convert to PDF
> Tips: `pwd` is `cairo/docs/reference`
> Tip: `pwd` is `cairo/docs/reference`

- Convert a single file
```bash
Expand Down
Loading