Deprecated const libfuncs for starknet types. #7302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
orizi
force-pushed
the
spr/main/e98c8f88
branch
2 times, most recently
from
f896955 to
7042b07
Compare
gilbens-starkware
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Reviewed 32 of 32 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @ArielElp)
orizi
force-pushed
the
spr/main/e98c8f88
branch
from
7042b07 to
bac8ce1
Compare
orizi
force-pushed
the
spr/main/e98c8f88
branch
from
bac8ce1 to
3b67f9a
Compare
orizi
force-pushed
the
spr/main/e98c8f88
branch
from
3b67f9a to
43b8b2f
Compare
orizi
force-pushed
the
spr/main/e98c8f88
branch
from
43b8b2f to
a9a0713
Compare
Specifically ClassHash and ContractClass. commit-id:e98c8f88
orizi
force-pushed
the
spr/main/e98c8f88
branch
from
a9a0713 to
107bb41
Compare
orizi
commented
Feb 18, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArielElp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically ClassHash and ContractClass.
Stack:
derive(starknet::Store)more hygienic. #7306core::starknetorcrate::starknet. #7304