Deprecated direct usages of core::starknet or crate::starknet.
#7304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 17, 2025
|
This change is |
orizi
requested review from
dean-starkware and
gilbens-starkware
and removed request for
dean-starkware
gilbens-starkware
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dean-starkware)
orizi
force-pushed
the
spr/main/3b4d7a14
branch
from
9d1ee4a to
1ca12fc
Compare
dean-starkware
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Reviewed 3 of 21 files at r1, all commit messages.
Reviewable status: 20 of 23 files reviewed, all discussions resolved (waiting on @gilbens-starkware)
orizi
force-pushed
the
spr/main/3b4d7a14
branch
from
1ca12fc to
457641b
Compare
orizi
force-pushed
the
spr/main/e98c8f88
branch
from
3b67f9a to
43b8b2f
Compare
orizi
force-pushed
the
spr/main/3b4d7a14
branch
from
457641b to
fae111c
Compare
orizi
force-pushed
the
spr/main/e98c8f88
branch
from
43b8b2f to
a9a0713
Compare
orizi
force-pushed
the
spr/main/3b4d7a14
branch
2 times, most recently
from
4cf3327 to
9fd1129
Compare
orizi
force-pushed
the
spr/main/e98c8f88
branch
from
a9a0713 to
107bb41
Compare
commit-id:3b4d7a14
orizi
force-pushed
the
spr/main/3b4d7a14
branch
from
9fd1129 to
782c0fb
Compare
TomerStarkware
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
derive(starknet::Store)more hygienic. #7306core::starknetorcrate::starknet. #7304 ⬅