Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the panic functions #[inline(never)]. #7385

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Made the panic functions #[inline(never)]. #7385

merged 1 commit into from
Mar 4, 2025

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Mar 4, 2025 •
edited
Loading

As we don't need them to be overly efficient.

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Mar 4, 2025
Merged
Merged
Merged
@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi requested a review from gilbens-starkware March 4, 2025 10:58
@orizi orizi force-pushed the spr/main/b187cb5a branch from 31de35a to cb1b40d Compare March 4, 2025 11:17
@orizi orizi force-pushed the spr/main/5bae7820 branch from 997e6b9 to 6e47384 Compare March 4, 2025 11:29
@orizi orizi force-pushed the spr/main/b187cb5a branch from cb1b40d to 93f7379 Compare March 4, 2025 11:29
@orizi orizi force-pushed the spr/main/5bae7820 branch from 6e47384 to fecdb10 Compare March 4, 2025 11:35
@orizi orizi force-pushed the spr/main/b187cb5a branch from 93f7379 to 0a40007 Compare March 4, 2025 11:35
@orizi orizi force-pushed the spr/main/5bae7820 branch from fecdb10 to f33f8f2 Compare March 4, 2025 11:37
@orizi orizi force-pushed the spr/main/b187cb5a branch from 0a40007 to e01f69d Compare March 4, 2025 11:37
@orizi orizi force-pushed the spr/main/5bae7820 branch from f33f8f2 to e6b3476 Compare March 4, 2025 11:58
@orizi orizi force-pushed the spr/main/b187cb5a branch from e01f69d to e5a9235 Compare March 4, 2025 11:58
@orizi orizi force-pushed the spr/main/5bae7820 branch from e6b3476 to bf04034 Compare March 4, 2025 12:12
@orizi orizi force-pushed the spr/main/b187cb5a branch from e5a9235 to 35d0e55 Compare March 4, 2025 12:12
gilbens-starkware
gilbens-starkware approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 79 of 79 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi
Made the panic functions #[inline(never)].
19f5616 
As we don't need them to be overly efficient.

commit-id:b187cb5a
@orizi orizi changed the base branch from spr/main/5bae7820 to main March 4, 2025 13:26
@orizi orizi force-pushed the spr/main/b187cb5a branch from 35d0e55 to 19f5616 Compare March 4, 2025 13:26
@orizi orizi enabled auto-merge March 4, 2025 13:26
@orizi orizi added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit 18742a2 Mar 4, 2025
92 checks passed
@orizi orizi deleted the spr/main/b187cb5a branch March 5, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbens-starkware gilbens-starkware gilbens-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orizi @reviewable-StarkWare @gilbens-starkware