Added panic_with_const_felt252 function and using it where possible.

[orizi]

Using it by:

• const-folding panic_with_felt252 into it.
• panic_with using it directly.
• gas addition using it directly.

---

Stack:

• Smaller sierra - actually properly using the panic vars. #7393
• Added panic_with_const_felt252 function and using it where possible. #7386 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[gilbens-starkware]

Reviewed 2 of 91 files at r1, all commit messages.
Reviewable status: 2 of 91 files reviewed, 1 unresolved discussion

---

a discussion (no related file):
Won't it create an instance of the function for each const and thus potentially increase the code size?

[orizi]

Reviewable status: 2 of 91 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

---

a discussion (no related file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Won't it create an instance of the function for each const and thus potentially increase the code size?

potentially - yes - in actuality - no.

most shorterrors repeat themselves - and we specifically don't care much about run cost of the panic area of the code (as it shouldn't happen)

[gilbens-starkware]

Reviewed 56 of 91 files at r1, 33 of 33 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)