Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor BLOCK_BODY_WITH_RECEIPTS #191

Merged
merged 2 commits into from
Feb 22, 2024
Merged

refactor BLOCK_BODY_WITH_RECEIPTS #191

merged 2 commits into from
Feb 22, 2024

Conversation

ArielElp
Copy link
Collaborator

@ArielElp ArielElp commented Feb 13, 2024

Removes the redundant block-related fields from the receipt, when appearing in a block with receipts request. To this end we're using the same objects that represent a transaction receipt in the pending block.


This change is Reviewable

Copy link

@DelevoXDG DelevoXDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)

@ArielElp ArielElp merged commit c198420 into master Feb 22, 2024
1 check passed
@ArielElp ArielElp deleted the fix_block_receipts branch February 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants