Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor BLOCK_BODY_WITH_RECEIPTS #191

Merged
merged 2 commits into from
Feb 22, 2024
Merged

refactor BLOCK_BODY_WITH_RECEIPTS #191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
964f314
remove rendundancy from block receipts
ArielElp Feb 13, 2024
fe8266c
update pending receipt fianlity status
ArielElp Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions api/starknet_api_openrpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,25 +1418,21 @@
"description": "The transactions in this block",
"type": "array",
"items": {
"title": "transactions in block",
"type": "object",
"allOf": [
{
"title": "transaction and receipt",
"properties": {
"transaction": {
"title": "transaction",
"$ref": "#/components/schemas/TXN"
},
{
"type": "object",
"properties": {
"receipt": {
"title": "receipt",
"$ref": "#/components/schemas/TXN_RECEIPT"
}
},
"required": [
"receipt"
]
"receipt": {
"title": "receipt",
"$ref": "#/components/schemas/TXN_RECEIPT_IN_BLOCK"
}
},
"required": [
"transaction",
"receipt"
]
}
}
Expand Down Expand Up @@ -2856,6 +2852,7 @@
},
"finality_status": {
"title": "Finality status",
"description": "finality status of the tx, which is ACCEPTED_ON_L2 when included in a pending receipt, and can be ACCEPTED_ON_L1 when part of a getBlockWithReceipts response",
"$ref": "#/components/schemas/TXN_FINALITY_STATUS"
},
"block_hash": {
Expand Down Expand Up @@ -3208,6 +3205,10 @@
}
]
},
"TXN_RECEIPT_IN_BLOCK": {
"title": "receipt in block",
"$ref": "#/components/schemas/PENDING_TXN_RECEIPT"
},
"PENDING_COMMON_RECEIPT_PROPERTIES": {
"title": "Pending common receipt properties",
"description": "Common properties for a pending transaction receipt",
Expand Down Expand Up @@ -3246,11 +3247,7 @@
},
"finality_status": {
"title": "Finality status",
"type": "string",
"enum": [
"ACCEPTED_ON_L2"
],
"description": "The finality status of the transaction"
"$ref": "#/components/schemas/TXN_FINALITY_STATUS"
},
"execution_status": {
"title": "Execution status",
Expand Down
Loading