Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and parsing timestamptz #23

Merged
merged 3 commits into from
Jan 1, 2022
Merged

Bug fixes and parsing timestamptz #23

merged 3 commits into from
Jan 1, 2022

Conversation

nkitsaini
Copy link
Contributor

@nkitsaini nkitsaini commented Dec 8, 2021

There are total three changes. Two simple bug fixes and one change to include timestamptz and timetz parsing. I've seen the comment regarding letting user decide the timezone, but I think that's not valid because timestamptz will contain the timezone information itself so there's no need for user to manually specify that.

@J0
Copy link
Contributor

J0 commented Dec 31, 2021

Hey @nkitsaini ,

Thanks for the PR and sorry for taking this long to get back. I think you raise some valid points and would be happy to merge this PR once the conflicts have been resolved.

Thanks!

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 31, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 10.29 🙂 10.29 🙂 0.00
Method Length 35.81 ⭐ 35.81 ⭐ 0.00
Working memory 10.37 😞 10.37 😞 0.00
Quality 64.65% 🙂 64.65% 🙂 0.00%
Other metrics Before After Change
Lines 172 170 -2
Changed files Quality Before Quality After Quality Change
realtime/transformers.py 64.65% 🙂 64.65% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
realtime/transformers.py convert_cell 27 😞 246 ⛔ 23 ⛔ 19.38% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@nkitsaini
Copy link
Contributor Author

Hey @J0

Thanks for getting back. I've resolved the conflicts.

@J0 J0 merged commit 7299676 into supabase:master Jan 1, 2022
@J0
Copy link
Contributor

J0 commented Jan 1, 2022

@nkitsaini merged, thanks for the PR! Feel free to ping me on discord(@AceOfSpade) if you'd like some Supabase stickers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants