Bug fixes and parsing timestamptz (Sourcery refactored) #24
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
sourcery/pull-23
branch
from
6914541 to
21bb369
Compare
sourcery-ai
bot
force-pushed
the
sourcery/pull-23
branch
from
21bb369 to
05920c6
Compare
| result = {} | ||
| skip_types = options.get("skip_types") if options.get( | ||
| "skip_types") == "undefined" else [] | ||
| for key in records.keys(): | ||
| result[key] = convert_column(key, columns, records, skip_types) | ||
| return result | ||
| return { | ||
| key: convert_column(key, columns, records, skip_types) | ||
| for key in records.keys() | ||
| } |
There was a problem hiding this comment.
Function convert_change_data refactored with the following changes:
- Convert for loop into dictionary comprehension (
dict-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| if string_value == None: | ||
| if string_value is None: |
There was a problem hiding this comment.
Function convert_cell refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
| string_array = string_enriched.split( | ||
| ",") if len(string_enriched) > 0 else [] | ||
| array = list(map(lambda string: convert_cell(type, string), string_array)) | ||
| return array | ||
| return list(map(lambda string: convert_cell(type, string), string_array)) |
There was a problem hiding this comment.
Function to_array refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.63%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #23 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!