Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with considering breadcrumbs on failing pages #28

Closed
wants to merge 4 commits into from
Closed

Fixed issue with considering breadcrumbs on failing pages #28

wants to merge 4 commits into from

Conversation

JPTouron
Copy link

  • Overridden OnResultExecuted on BreadCrumbAttribute class to remove the crumb when the action result fails
  • Cleaned up code
  • also modified BreadCrumb class DisplayRaw method to display the breadcrumbs with the same logic as Display method (setting the non-current crumbs as links) and also allowed the concatenator ( '>' ) to be parameterized, defaulting to '>'

@thelarz thelarz closed this Oct 30, 2017
@thelarz
Copy link
Owner

thelarz commented Nov 8, 2017

For some reason (I think accidental) I closed this PR. Reopening.

@thelarz thelarz reopened this Nov 8, 2017
@JPTouron JPTouron closed this Jan 11, 2018
@JPTouron
Copy link
Author

closed pull request as there were too many conflicts, will merge with your master onto mine and re-implement my fix as it was not all too complex

@JPTouron JPTouron mentioned this pull request Jan 11, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JPTouron @thelarz