Fixed issue with considering breadcrumbs on failing pages

MvcBreadCrumbs/BreadCrumb.cs

@@ -39,6 +39,15 @@ internal static IHierarchyProvider HierarchyProvider
 
 		public static void Add(string url, string label)
 		{
+            // get a key for the Url.
+            var key =
+               url
+               .ToLower()
+               .GetHashCode();
+
+            var current = new StateEntry().WithKey(key)
+             .WithUrl(url)
+             .WithLabel(label);
 			var state = StateManager.GetState(SessionProvider.SessionId);
 			state.Push(url, label);
 		}
@@ -145,21 +154,24 @@ public static string Display(string cssClassOverride = "breadcrumb")
 			return sb.ToString();
 
 		}
-		public static string DisplayRaw()
-		{
-
-			var state = StateManager.GetState(SessionProvider.SessionId);
+        public static string DisplayRaw(string crumbConcatenator = ">")
+        {
+            var state = StateManager.GetState(SessionProvider.SessionId);
 
-			if (state.Crumbs != null && !state.Crumbs.Any())
-				return "<!-- BreadCrumbs stack is empty -->";
+            if (state.Crumbs != null && !state.Crumbs.Any())
+                return "<!-- BreadCrumbs stack is empty -->";
 
 			// don't allow blank labels to propagate outside
 			state.Crumbs.ToList().ForEach(x => { x.Label = string.IsNullOrWhiteSpace(x.Label) ? x.Action : x.Label; });
-
-			return string.Join(" > ",
-				state.Crumbs.Select(x => "<a href=\"" + x.Url + "\">" + x.Label + "</a>").ToArray());
-
-		}
+            return string.Join("  " + crumbConcatenator + " ",
+                state.Crumbs.Select(x =>
+                {
+                    if (IsCurrentPage(x.Key))
+                        return x.Label;
+                    else
+                        return "<a href=\"" + x.Url + "\">" + x.Label + "</a>";
+                }).ToArray());
+        }
 
 		private static bool IsCurrentPage(int compareKey)
 		{

MvcBreadCrumbs/BreadCrumbAttribute.cs

@@ -35,6 +35,18 @@ private static IProvideBreadCrumbsSession SessionProvider
 			}
 		}
 
+        public override void OnResultExecuted(ResultExecutedContext filterContext)
+        {
+            if (filterContext.Exception != null)
+            {
+                //if we have an exception on the result (for ANY reason), let's make sure that we don't
+                //track this failing page on the breadcrumb
+                var state = StateManager.GetState(SessionProvider.SessionId);
+                state.OnErrorRemoveCrumb(filterContext);
+            }
+
+            base.OnResultExecuted(filterContext);
+        }
 		public override void OnActionExecuting(ActionExecutingContext filterContext)
 		{
 

MvcBreadCrumbs/State.cs

@@ -68,9 +68,30 @@ private void Add(string url, string label, Type resourceType = null, ActionExecu
 				.WithLevel(levels)
 				.WithLabel(ResourceHelper.GetResourceLookup(resourceType, label));
 
-			Crumbs.Add(Current);
-		}
-	}
+            Crumbs.Add(Current);
+        }
+
+
+        /// <summary>
+        /// provides a way to remove a crumb from the crumbs list
+        /// </summary>
+        /// <param name="context"></param>
+        public void OnErrorRemoveCrumb(ResultExecutedContext context)
+        {
+            var key =
+                context.HttpContext.Request.Url.LocalPath
+                .ToLower()
+                .GetHashCode();
+
+            if (Crumbs.Any(x => x.Key == key))
+            {
+                var crumb = Crumbs.Single(x => x.Key == key);
+                Crumbs.Remove(crumb);
+            }
+        }
+
+
+    }
 
 	public class StateEntry
 	{