TravisCI: include pages of all languages in archive

[arunisaac]

Now that we are supporting pages in multiple natural languages (#2339), we need to include all those pages in the tldr archive.

[agnivade]

Why not just pages*/ ?

[waldyrious]

Does it even work with the . there, considering that the English pages directory does not have a suffix?

[owenvoke]

@waldyrious, I assume it would in the initial one as it has pages/ pages.*/ so that would catch both.

[waldyrious]

Oh yeah hahah, I totally misinterpreted the diff!

[arunisaac]

- zip -r $TLDR_ARCHIVE pages/ LICENSE.md + zip -r $TLDR_ARCHIVE pages/ pages.*/ LICENSE.md Why not just `pages*/` ?

That should work as well. I just didn't think of it.

[waldyrious]

@arunisaac just for reference, github's squash option does not automatically interpret the fixup! directive in the commit message. I had to manually remove the second commit's message when merging. It's certainly something that would be nice for them to support.

[arunisaac]

Waldir Pimenta <[email protected]> writes:

@arunisaac just for reference, github's squash option does not automatically interpret the `fixup!` directive in the commit message.

Yes, I suspected as much. In the future, should I use the "fixup!" prefix? Or, is there some other preferred way for github to automatically recognize commit messages to be squashed?

[waldyrious]

In the future, should I use the "fixup!" prefix?

It's up to you. Maintainers should ask in case they need git actions from the contributor, anyway. In this case, what needed to happen was pretty straightforward (and could be done in the merge process) so I just went ahead and did it.

is there some other preferred way for github to automatically recognize commit messages to be squashed?

Not that I know of. :/