Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages.zh/windows: add Chinese translation #2826

Merged
merged 87 commits into from
Mar 12, 2019

Conversation

starccy
Copy link
Contributor

@starccy starccy commented Mar 11, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@mebeim mebeim added the translation Issues requesting translating pages from English to other languages. label Mar 11, 2019
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starccy if I may ask, how are you using these translations in your day-to-day work ? Since none of the clients support it yet.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks @starccy!

Yeah, @agnivade - we should probably look at adding client support at some point lol

Currently I'm too busy though, as it's University semester time :-(

@sbrl sbrl merged commit f172b9e into tldr-pages:master Mar 12, 2019
@starccy
Copy link
Contributor Author

starccy commented Mar 12, 2019

@agnivade To be honest, I may want to ask the same question...

@sbrl
Copy link
Member

sbrl commented Mar 12, 2019

lol!

I'm sure that with the number of pages we have now in other languages, client authors can implement support. @pepa65, is this something that the bash client could support - especially with #2706 being recently closed?

@pepa65
Copy link
Contributor

pepa65 commented Mar 12, 2019

I was planning to implement that once sufficient interest (read: available translated pages) is there.
But note that my client is no longer compliant under the new specs, because it uses the tldr platform/page syntax, and that's the way I like it. I don't want to be typing tldr -p platform page, a bit stubborn perhaps, but I am sure users can adapt..?

@pepa65
Copy link
Contributor

pepa65 commented Mar 12, 2019

Are these translated pages going to be added to the zip archive??

@sbrl
Copy link
Member

sbrl commented Mar 12, 2019

They should be in the zip archive already I think, because of #2567, @pepa65 - though if you're not seeing them there might be a bug

Personally I like the tldr platform/page syntax best too. I hope your client keeps supporting it :D

@agnivade
Copy link
Member

@starccy - So you are spending non-trivial amount of time translating these pages without any direct result ? That is some serious dedication. Thanks !

@pepa65
Copy link
Contributor

pepa65 commented Mar 12, 2019

I must have the wrong zip... 👎 What is the right URL? (I'm using http://tldr.sh/assets/tldr.zip which has an index.json that includes more languages, but no actual pages...)

@sbrl
Copy link
Member

sbrl commented Mar 14, 2019

The new Client Spec should contain the right URL. If that doesn't work, could you open an issue please, @pepa65?

@pepa65
Copy link
Contributor

pepa65 commented Mar 14, 2019

The link in the spec just opens up de general repo. I think the build instructions for the zipfile on http://tldr.sh/assets should be made to include all pages* directories.

@owenvoke
Copy link
Member

@pepa65, it does when I download it. 🤔

@mttbernardini
Copy link

@pepa65 I can reproduce what happens to @pxgamer

@owenvoke
Copy link
Member

Oh. Are you talking about adding an index.json to each directory? That makes sense.

@pepa65
Copy link
Contributor

pepa65 commented Mar 14, 2019

My mistake, my client was only unpacking the pages directory, not the whole archive..!
For anyone that (ab)uses the index.json, it will be important for every pages* directory to have one (that, or one general one in the top level, but that will break old clients that use the index.json).

@owenvoke
Copy link
Member

Glad you worked it out 👍

I'd see it as being better for an index.json per pages directory. 🤔

@pepa65
Copy link
Contributor

pepa65 commented Mar 14, 2019

I opened a new Issue for getting a index.json built for every language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Issues requesting translating pages from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants