CLDR-16534 rename-islamic-to-hijri

[stenshamn]

CLDR-16534

• This PR completes the ticket.

Note I also checked root.xml but it had no instances of this string, so it's English only.

ALLOW_MANY_COMMITS=true

[pedberg-icu]

@stenshamn Need to update the expected results in common/testData/localeIdentifiers/localeDisplayName.txt (search for Islamic...)

[pedberg-icu]

Need to update the expected results in common/testData/localeIdentifiers/localeDisplayName.txt (search for Islamic...) so tests pass.

It would also be good to update the descriptions for the islamic calendars in common/bcp47/calendar.xml

[stenshamn]

BTW, is the misspelling "islamicc" on line 32 intentional or should we fix that too?

[pedberg-icu]

Yes, that is intentional, it is an (old) identifier not a name

[stenshamn]

Also noting that I will hold off on merging this until #2951 is approved and merged, since we need both for the ticket.

[jira-pull-request-webhook]

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

[pedberg-icu]

Looks good now, thanks!

And no reason to hold off merging this until #2951 is merged, they do not conflict and do not need to be merged in a particular order.

[pedberg-icu]

I will go ahead and merge....

[macchiati]

Made a new PR for the results of running the tool

…

On Thu, May 25, 2023 at 12:12 PM Peter Edberg ***@***.***> wrote: Merged #2954 <#2954> into main. — Reply to this email directly, view it on GitHub <#2954 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMA5GAEGPMAO7LO36X3XH6VLVANCNFSM6AAAAAAYN5VR5M> . You are receiving this because your review was requested.Message ID: ***@***.***>