Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change API name of Islamic to Hijri in code #6214

Closed
sffc opened this issue Feb 28, 2025 · 0 comments
Closed

Change API name of Islamic to Hijri in code #6214

sffc opened this issue Feb 28, 2025 · 0 comments
Assignees
@robertbastian
Labels
2.0-breaking Changes that are breaking API changes C-calendar Component: Calendars
Milestone
ICU4X 2.0 ⟨P1⟩

Comments

@sffc
Copy link
Member

sffc commented Feb 28, 2025 •
edited
Loading

In unicode-org/cldr#2954, CLDR changed the display names of the Islamic calendars to Hijri, without changing the BCP-47 codes. We should do the same in the ICU4X API. This would mean that the following names would change:

Old New
IslamicCivil HijriCivil
IslamicObservational HijriObservational
IslamicTabular HijriTabular
IslamicUmmAlQura HijriUmmAlQura

Might also impact data marker names.

Also see #6210.
@sffc sffc added the 2.0-breaking Changes that are breaking API changes label Feb 28, 2025
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Feb 28, 2025
@sffc sffc added the C-calendar Component: Calendars label Feb 28, 2025
@robertbastian robertbastian self-assigned this Mar 5, 2025
@robertbastian robertbastian mentioned this issue Mar 5, 2025
Merged
robertbastian added a commit that referenced this issue Mar 5, 2025
@robertbastian
Rename Islamic calendars to Hijri (#6225)
dd4a7e5 
#6214 

* ~Can we change the era code to be `hijri` instead of `islamic`?~
* ~it could also be `ah`, given that other calendars use (Latin)
abbreviations~
* `calendrical_calculations` also uses "islamic", do we want to change
that?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertbastian robertbastian

Labels
2.0-breaking Changes that are breaking API changes C-calendar Component: Calendars
Projects
None yet
Milestone
ICU4X 2.0 ⟨P1⟩
Development

No branches or pull requests
2 participants
@sffc @robertbastian