Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update to Sphinx 7 #1056

Merged
merged 1 commit into from
Nov 7, 2023
Merged

⬆️ Update to Sphinx 7 #1056

merged 1 commit into from
Nov 7, 2023

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Nov 2, 2023

The principle goal of this PR is to update code/tests to allow for use with sphinx 7 and upgrade to Python 3.8-3.11.
To do this a number of other changes are made:

  • The development dependency configuratio, in pyproject.toml, is modified to use separate extras for tests, benchmarks and docs
    • This allows for the docs/requirements.txt to be removed
  • The noxfile now directly calls pytest/sphinx, rather than call make. This removes a confusing indirection, and allows for passing arguments to sessions: https://nox.thea.codes/en/stable/config.html#passing-arguments-into-sessions
  • The CI now also directly calls pytest, again removing confusing indirections
    • The tests are split into core and JS tests (JS were previously not actually run)
  • The typing_extensions backport for python<=3.7 is removed
  • The sphinxcontrib-jquery dependency is added, which re-adds the jquery JavaScript removed in sphinx>=6
    • This fixes the JS tests for sphinx 7

@chrisjsewell chrisjsewell changed the title ⬆️ Update for Sphinx 7 ⬆️ Update for Python 3.8, Sphinx 7 Nov 2, 2023
@chrisjsewell chrisjsewell force-pushed the update-sphinx-7 branch 3 times, most recently from 105f52b to 575c62b Compare November 6, 2023 10:36
@chrisjsewell chrisjsewell marked this pull request as ready for review November 6, 2023 13:10
@chrisjsewell chrisjsewell requested a review from danwos November 6, 2023 13:10
@chrisjsewell chrisjsewell changed the title ⬆️ Update for Python 3.8, Sphinx 7 ⬆️ Update to Sphinx 7 Nov 6, 2023
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work getting it running for 7.x 👍

@chrisjsewell chrisjsewell merged commit d7ae061 into master Nov 7, 2023
@chrisjsewell chrisjsewell deleted the update-sphinx-7 branch November 7, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants