♻️ Make matplotlib dependency optional #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjsewell
force-pushed
the
make-matplotlib-optional
branch
from
7b2074c to
24f95ad
Compare
10 tasks
|
yes please 🙏 thanks for picking this up same issue as superceded PR though, lack of tests without matplotlib present? |
chrisjsewell
force-pushed
the
make-matplotlib-optional
branch
from
f43b545 to
2217df5
Compare
chrisjsewell
force-pushed
the
make-matplotlib-optional
branch
from
2217df5 to
8573961
Compare
danwos
approved these changes
Nov 8, 2023
|
Congrats @chrisjsewell, you got it across the line for us all \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes #493
It makes matplotlib and numpy optional dependencies, using
pip install sphinx-needs[plotting], by:NoneNonecase in theneedbar/needpiepost-processing, by emmiting a warning and replacing the nodes with error admonitions.A seperate test job and related test file is added for testing builds with needbar/needpie directives, when matplotlib is uninstalled.