Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Add code coverage to CI testing #1067

Merged
merged 2 commits into from
Nov 13, 2023
Merged

🧪 Add code coverage to CI testing #1067

merged 2 commits into from
Nov 13, 2023

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Nov 8, 2023

Add code coverage information to CI testing with https://app.codecov.io

@chrisjsewell chrisjsewell changed the title ♻️ Make matplotlib optional 🧪 Add code coverage to CI testing Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@chrisjsewell chrisjsewell marked this pull request as ready for review November 8, 2023 15:32
@chrisjsewell chrisjsewell requested a review from danwos November 8, 2023 15:36
@chrisjsewell chrisjsewell merged commit a8ab520 into master Nov 13, 2023
@chrisjsewell chrisjsewell deleted the add-code-cov branch November 13, 2023 10:28
chrisjsewell added a commit that referenced this pull request Mar 25, 2024
In #1067 I added coverage uploads.
@PhilipPartsch has uncovered an issue with this; it appears at least in Windows if `pytest` fails it still progresses to the next command `coverage xml` and then if this runs ok it doesn't mark the job step as failing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants