🧪 Fix Windows pytest CI runs

[chrisjsewell]

In #1067 I added coverage uploads.
@PhilipPartsch has uncovered an issue with this; it appears at least in Windows if pytest fails it still progresses to the next command coverage xml and then if this runs ok it doesn't mark the job step as failing 🤦

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (0f71ecd) to head (fe32850).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1153   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files          56       56           
  Lines        6536     6536           
=======================================
  Hits         5616     5616           
  Misses        920      920           

Flag	Coverage Δ
pytests	85.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrisjsewell]

Now I just need to fix the failures 😅

[PhilipPartsch]

Now I just need to fix the failures 😅

I have the fixes available at my privet PC at home. I can commit them in 12 hours.

[chrisjsewell]

I have the fixes available at my privet PC at home. I can commit them in 12 hours.

thanks!

[PhilipPartsch]

I have the fixes available at my privet PC at home. I can commit them in 12 hours.

thanks!

My fixes are here

[chrisjsewell]

@PhilipPartsch for future knowledge, this is the root problem: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference

cmd: There doesn't seem to be a way to fully opt into fail-fast behavior other than writing your script to check each error code and respond accordingly. Because we can't actually provide that behavior by default, you need to write this behavior into your script.

Windows being window 😅