CI: Drop figure size nbval check
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
CI is passing for the scope of this PR; remaining fails are linked to #265 and will be dealt with separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
T025+26: Apparently, the default figure size increased from 432x288 to 640x480 (in Jupyter Lab and Notebook).
nbvalcheck because I think it is enough to be informed if the cell fails instead of if the string(<Figure size 432x288 with 1 Axes>, <AxesSubplot:>)changes; both figure sizes are fine :)nbval-checking plots in other talktorials. I might have missed some cases, but we usually do not.Status