Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T021/22: Deprecated tensorflow imports? #265

Closed
Tracked by #296
dominiquesydow opened this issue Aug 23, 2022 · 2 comments · Fixed by #267 or #296
Closed
Tracked by #296

T021/22: Deprecated tensorflow imports? #265

dominiquesydow opened this issue Aug 23, 2022 · 2 comments · Fixed by #267 or #296
Assignees
Labels
dependency Update/fix dependencies

Comments

@dominiquesydow
Copy link
Collaborator

Description

Our scheduled CI shows fails for tensorflow imports on Windows. Compared to last week (passing CI), the installed tensorflow versions changed from 2.6 to 2.8.

ModuleNotFoundError: No module named 'tensorflow.python.keras.preprocessing'

Todos

@dominiquesydow
Copy link
Collaborator Author

dominiquesydow commented Sep 1, 2022

I am confused by the following observation about the tensorflow versions that are installed in our CI runs. Leaving a summary here:

We ask for tensorflow>=2.0 (here) and specify the conda channels conda-forge and defaults (in that order!).
Let's check which tensorflow versions are installed vs. which I would expect (*) based on the latest conda-forge and defaults releases:

CI setup observed CI version expected CI version conda-forge version defaults version
Ubuntu Py3.8/3.9 2.4.1 2.9.1 2.9.1* 2.9.1
macOS Py3.8 2.4.1 2.9.1 2.9.1* 2.0.0
Windows Py3.9 2.8.2 2.8.2 1.14.0 2.8.2*
Windows Py3.8 2.3.0 2.8.2 1.14.0 2.8.2*

Maybe other dependencies in our teachopencadd environment prevent the installation of the lastest tensorflow versions?

Why do I care? It seems that there was an API change from tensorflow version 2.6.0 (last passing Win CI) to 2.8.2. Hence our T021 and T022 should get a refactoring based on the latest tensorflow version, no?
See deprecation note: https://www.tensorflow.org/api_docs/python/tf/keras/preprocessing

@dominiquesydow
Copy link
Collaborator Author

After consultation with @t-kimber, we concluded that our usage of tensorflow in T021 and T022 is basic enough to justify sticking to the API as of version 2.6. Hence, I am pinning tensorflow<=2.6, which should allow running the talktorials for all OS and Python 3.8 and 3.9.

Change is incorporated in PR #267, see #267 (comment).

@dominiquesydow dominiquesydow linked a pull request Sep 2, 2022 that will close this issue
3 tasks
@dominiquesydow dominiquesydow changed the title T021+22: Deprecated tensorflow imports? T021/22: Deprecated tensorflow imports? Dec 27, 2022
@dominiquesydow dominiquesydow linked a pull request Dec 30, 2022 that will close this issue
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Update/fix dependencies
Projects
None yet
1 participant