CI: Revert Win Py3.9 back to Py3.8; pin tensorflow<=2.6
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiquesydow
changed the title
tensorflow<=2.6
|
After consultation with @t-kimber, we concluded that our usage of |
|
Hi @t-kimber, would you mind reviewing this PR? |
t-kimber
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Looks good to me! Thank you for looking into this, @dominiquesydow :)
I had a quick look at the changes made to the TensorFlow API after 2.6, and it doesn't seem to affect any of the functionalities that we are using in the notebooks, see https://github.com/tensorflow/tensorflow/releases/tag/v2.7.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking into the
tensorflowissue reported in #265, I noticed that we are running the CI for Windows under Py3.9 although we intended to run all platforms by default under Py3.8 (plus an additional test for Py3.9 under Linux).I introduced this discrepency when I made a CI test run for Win Py3.9 and forgot (?) to revert back to Py3.8: #254 (comment) (the exact commit: f1596b4)
Pin
tensorflowversion matching the API used in T021 and T022 (i.e. 2.6).Todos
tensorflow<=2.6Status