fix: respect `--color`/`--no-color` arguments #2042

snitin315 · 2020-11-05T03:51:29Z

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
no
Summary

stats colors should be disabled if we use --no-color.

Fixes #2038 as well

Before

After

Does this PR introduce a breaking change?
Nope

Other information
No

codecov · 2020-11-05T04:00:58Z

Codecov Report

Merging #2042 (8a3e10e) into master (cd56712) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2042      +/-   ##
==========================================
+ Coverage   68.50%   68.65%   +0.14%     
==========================================
  Files          76       76              
  Lines        2413     2418       +5     
  Branches      497      497              
==========================================
+ Hits         1653     1660       +7     
+ Misses        760      758       -2

Impacted Files	Coverage Δ
packages/webpack-cli/lib/utils/cli-flags.js	`100.00% <ø> (ø)`
packages/webpack-cli/lib/bootstrap.js	`100.00% <100.00%> (ø)`
packages/webpack-cli/lib/webpack-cli.js	`90.43% <100.00%> (+0.23%)`	⬆️
packages/generate-loader/src/index.ts	`100.00% <0.00%> (ø)`
packages/utils/src/modify-config-helper.ts	`54.38% <0.00%> (+0.28%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd56712...8a3e10e. Read the comment docs.

snitin315 · 2020-11-05T04:34:49Z

from CI -

webpack-4

webpack-5

test/colors/colors.test.js

packages/webpack-cli/lib/webpack-cli.js

alexander-akait

/cc @webpack/cli-team

Good job, thanks

alexander-akait

oh, what about logger? Because --no-colors should disable colors for logger too

snitin315 · 2020-11-05T11:54:11Z

oh, what about logger? Because --no-colors should disable colors for logger too

I will update 👍🏻

fixed

snitin315 · 2020-11-06T02:53:37Z

I will fix the CI problems soon.

packages/webpack-cli/lib/bootstrap.js

snitin315 · 2020-11-07T12:25:39Z

/cc @webpack/cli-team

alexander-akait

/cc @webpack/cli-team

snitin315 · 2020-11-09T15:45:38Z

Good to merge?

alexander-akait

/cc @webpack/cli-team

anshumanv · 2020-11-09T17:00:50Z

Thanks for waiting, I'm on it 👍

anshumanv

minor nits

packages/webpack-cli/lib/bootstrap.js

packages/webpack-cli/lib/webpack-cli.js

Co-authored-by: Anshuman Verma <[email protected]>

webpack-bot · 2020-11-09T17:44:18Z

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@anshumanv Please review the new changes.

packages/webpack-cli/lib/bootstrap.js

alexander-akait · 2020-11-09T18:40:11Z

/cc @webpack/cli-team focus on it, it is blocker for other refactor arg parser

packages/webpack-cli/lib/webpack-cli.js

anshumanv

Thanks

alexander-akait

Feel free to merge after CI green

alexander-akait · 2020-11-09T20:18:32Z

random fail on macos, let's ignore, we will return to this if it happens again

webpack-bot added the PR: unreviewed label Nov 5, 2020

snitin315 marked this pull request as ready for review November 5, 2020 04:37

snitin315 requested a review from a team as a code owner November 5, 2020 04:37

alexander-akait reviewed Nov 5, 2020

View reviewed changes

test/colors/colors.test.js Outdated Show resolved Hide resolved

alexander-akait reviewed Nov 5, 2020

View reviewed changes

packages/webpack-cli/lib/webpack-cli.js Outdated Show resolved Hide resolved

snitin315 force-pushed the fix/stats-color branch from 1615bfa to 2faaaa1 Compare November 5, 2020 11:39

alexander-akait approved these changes Nov 5, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: unreviewed labels Nov 5, 2020

alexander-akait previously requested changes Nov 5, 2020

View reviewed changes

webpack-bot added the PR: reviewed-changes-requested label Nov 5, 2020

rishabh3112 previously approved these changes Nov 5, 2020

View reviewed changes

snitin315 dismissed rishabh3112’s stale review via 60cd78d November 6, 2020 01:43

webpack-bot added PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Nov 6, 2020

snitin315 force-pushed the fix/stats-color branch from 60cd78d to 7d03569 Compare November 6, 2020 01:58

alexander-akait reviewed Nov 6, 2020

View reviewed changes

packages/webpack-cli/lib/bootstrap.js Show resolved Hide resolved

This was referenced Nov 7, 2020

fix: remove default value for devtool #2053

Merged

fix: merge resolvers #2049

Merged

snitin315 force-pushed the fix/stats-color branch 4 times, most recently from 232dea6 to d30018f Compare November 7, 2020 06:32

tests: colors

abeff02

alexander-akait approved these changes Nov 9, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Nov 9, 2020

alexander-akait previously approved these changes Nov 9, 2020

View reviewed changes

alexander-akait mentioned this pull request Nov 9, 2020

Refactor code #2048

Merged

snitin315 requested a review from anshumanv November 9, 2020 16:57

anshumanv requested changes Nov 9, 2020

View reviewed changes

packages/webpack-cli/lib/bootstrap.js Show resolved Hide resolved

packages/webpack-cli/lib/webpack-cli.js Show resolved Hide resolved

webpack-bot added the PR: reviewed-changes-requested label Nov 9, 2020

chore: suggestion

27e976c

Co-authored-by: Anshuman Verma <[email protected]>

snitin315 dismissed alexander-akait’s stale review via 27e976c November 9, 2020 17:44

webpack-bot added PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Nov 9, 2020

alexander-akait reviewed Nov 9, 2020

View reviewed changes

packages/webpack-cli/lib/bootstrap.js Outdated Show resolved Hide resolved

snitin315 commented Nov 9, 2020

View reviewed changes

packages/webpack-cli/lib/webpack-cli.js Outdated Show resolved Hide resolved

snitin315 commented Nov 9, 2020

View reviewed changes

packages/webpack-cli/lib/webpack-cli.js Outdated Show resolved Hide resolved

fix: ci

8a3e10e

anshumanv approved these changes Nov 9, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Nov 9, 2020

alexander-akait approved these changes Nov 9, 2020

View reviewed changes

alexander-akait merged commit 09bd812 into master Nov 9, 2020

alexander-akait deleted the fix/stats-color branch November 9, 2020 20:19

snitin315 changed the title ~~fix: allow to disable stats color via --no-color~~ fix: respect --color/--no-color arguments Nov 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: respect `--color`/`--no-color` arguments #2042

fix: respect `--color`/`--no-color` arguments #2042

snitin315 commented Nov 5, 2020 •

edited

Loading

codecov bot commented Nov 5, 2020 •

edited

Loading

snitin315 commented Nov 5, 2020 •

edited

Loading

alexander-akait left a comment

alexander-akait left a comment •

edited

Loading

snitin315 commented Nov 5, 2020

snitin315 commented Nov 6, 2020

snitin315 commented Nov 7, 2020

alexander-akait left a comment

snitin315 commented Nov 9, 2020

alexander-akait left a comment

anshumanv commented Nov 9, 2020

anshumanv left a comment

webpack-bot commented Nov 9, 2020

alexander-akait commented Nov 9, 2020

anshumanv left a comment

alexander-akait left a comment

alexander-akait commented Nov 9, 2020

fix: respect --color/--no-color arguments #2042

fix: respect --color/--no-color arguments #2042

Conversation

snitin315 commented Nov 5, 2020 • edited Loading

Before

After

codecov bot commented Nov 5, 2020 • edited Loading

Codecov Report

snitin315 commented Nov 5, 2020 • edited Loading

from CI -

alexander-akait left a comment

Choose a reason for hiding this comment

alexander-akait left a comment • edited Loading

Choose a reason for hiding this comment

snitin315 commented Nov 5, 2020

snitin315 commented Nov 6, 2020

snitin315 commented Nov 7, 2020

alexander-akait left a comment

Choose a reason for hiding this comment

snitin315 commented Nov 9, 2020

alexander-akait left a comment

Choose a reason for hiding this comment

anshumanv commented Nov 9, 2020

anshumanv left a comment

Choose a reason for hiding this comment

webpack-bot commented Nov 9, 2020

alexander-akait commented Nov 9, 2020

anshumanv left a comment

Choose a reason for hiding this comment

alexander-akait left a comment

Choose a reason for hiding this comment

alexander-akait commented Nov 9, 2020

fix: respect `--color`/`--no-color` arguments #2042

fix: respect `--color`/`--no-color` arguments #2042

snitin315 commented Nov 5, 2020 •

edited

Loading

codecov bot commented Nov 5, 2020 •

edited

Loading

snitin315 commented Nov 5, 2020 •

edited

Loading

alexander-akait left a comment •

edited

Loading