-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove default value for devtool #2053
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2053 +/- ##
==========================================
- Coverage 68.81% 68.31% -0.51%
==========================================
Files 82 77 -5
Lines 2437 2408 -29
Branches 494 496 +2
==========================================
- Hits 1677 1645 -32
- Misses 760 763 +3 Continue to review full report at Codecov.
|
negative: true, | ||
defaultValue: true, | ||
description: 'Enable/Disable colors on console', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the color
needs some more fixes, I'm removing it in
#2042 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove it for devtool
only here.
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
Remove the default value of some flags since they are invalid and not used in most cases.
Does this PR introduce a breaking change?
No
Other information