Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant .version file #328

Closed
piotrowski opened this issue Dec 30, 2020 · 1 comment · Fixed by #338
Closed

Redundant .version file #328

piotrowski opened this issue Dec 30, 2020 · 1 comment · Fixed by #338
Assignees
@szymon-owczarzak
Labels
bug Something isn't working

Comments

@piotrowski
Copy link

Hello! I found a bug (and I have a feature proposal).

Bug: There is no .version file on your 1.0.1 release. Project will not start because of that.

Feature: As a administrator, If I would see information, that there is new version available, I would prefer simply bump versions in my docker-compose.yml. And that should be all. Right now I have to bump version inside .version file also which is IMO redundant.

I think you could inject .version file while building image (with --build-args flag) and echo it to file somewhere. This way you will be able to use simple docker-compose.yml without any additional files
@szymon-owczarzak szymon-owczarzak added the bug Something isn't working label Dec 30, 2020
@szymon-owczarzak szymon-owczarzak self-assigned this Dec 30, 2020
@szymon-owczarzak
Copy link
Contributor

I will have a look at how to fix this.

@szymon-owczarzak szymon-owczarzak linked a pull request Mar 4, 2021 that will close this issue
#328 | Redundant .version file removed #338
Merged
7 tasks
szymon-owczarzak added a commit that referenced this issue Mar 11, 2021
@szymon-owczarzak
#328 | Redundant .version file removed (#338)
5b2e50c 
Removing .version file

Co-authored-by: szymon.owczarzak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymon-owczarzak szymon-owczarzak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#328 | Redundant .version file removed wttech/cogboard
2 participants
@piotrowski @szymon-owczarzak