#328 | Redundant .version file removed #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 29, 2021 13:41
Closed
szymon-owczarzak
commented
Mar 5, 2021
Comment on lines
+21
to
+22
| environment: | ||
| - COGBOARD_VERSION=${COGBOARD_VERSION} |
There was a problem hiding this comment.
The Cogboard version is now provided by docker as a system environment variable.
szymon-owczarzak
commented
Mar 5, 2021
Comment on lines
-160
to
-167
| register("createVersionFile") { | ||
| File(mountDir, ".version").writeText(""" | ||
| { | ||
| "version": "$version" | ||
| } | ||
| """.trimIndent()) | ||
| mustRunAfter("copyConfigs") | ||
| } |
There was a problem hiding this comment.
no need for that anymore...
yahorm
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.versionfile containing version number was redundant togradle.propertiesfile.The backend will now use an environment variable
COGBOARD_VERSIONwhich is a part of compose files.Types of changes
Checklist:
I hereby agree to the terms of the Cogboard Contributor License Agreement.