Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "debug mode" public API #1560

Closed
Tyriar opened this issue Jul 9, 2018 · 1 comment · Fixed by #2304
Closed

Make "debug mode" public API #1560

Tyriar opened this issue Jul 9, 2018 · 1 comment · Fixed by #2304
Assignees
@Tyriar
Labels
area/api type/enhancement Features or improvements to existing features
Milestone
4.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 9, 2018 •
edited
Loading

Right now you run term._core.debug = true (and term.setOption('debug', true)), we should probably just make this public API

https://github.com/xtermjs/xterm.js/wiki/Contributing#enabling-debug-mode

It might also be good to changing it to "logging level" instead of "debug mode".
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/api labels Jul 9, 2018
@jerch jerch mentioned this issue Sep 14, 2018
Merged
2 tasks
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 13, 2019
@Tyriar
Introduce logLevel option
94199ae 
Part of xtermjs#1560
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 13, 2019
@Tyriar
Use log service everywhere, fix log printing
2977a53 
Fixes xtermjs#1560
@Tyriar Tyriar mentioned this issue Jul 13, 2019
Merged
@Tyriar Tyriar added this to the 4.0.0 milestone Jul 13, 2019
@Tyriar Tyriar self-assigned this Jul 13, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jul 13, 2019

Doc update part moved to #2305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/api type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Use IBufferService for buffer access in InputHandler Tyriar/xterm.js
1 participant
@Tyriar