Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a tslint rule to prevent importing from lib #1996

Closed
Tyriar opened this issue Apr 3, 2019 · 0 comments · Fixed by #2311
Closed

Create a tslint rule to prevent importing from lib #1996

Tyriar opened this issue Apr 3, 2019 · 0 comments · Fixed by #2311
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
4.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 3, 2019

Because of the change to project references, it appears that it's easy to import the lib version of the file where the .d.ts lives using TS refactors. We should have a lint rule that prevents this as src/ should never reference lib/
@Tyriar Tyriar added help wanted type/debt Technical debt that could slow us down in the long run labels Apr 3, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 11, 2019
@Tyriar
Fix bad import from lib
c04ebe9 
Related xtermjs#1996
@Tyriar Tyriar mentioned this issue May 11, 2019
Merged
@Tyriar Tyriar closed this as completed May 25, 2019
@Tyriar Tyriar reopened this Jul 14, 2019
@Tyriar Tyriar added this to the 4.0.0 milestone Jul 14, 2019
@Tyriar Tyriar self-assigned this Jul 14, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 14, 2019
@Tyriar
Add tslint rule to prevent import from out
8deef83 
Fixes xtermjs#1996
@Tyriar Tyriar mentioned this issue Jul 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Move range updating to DirtyRowService and add dependency injection Tyriar/xterm.js
1 participant
@Tyriar