Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move range updating to DirtyRowService and add dependency injection #2311

Merged
merged 14 commits into from
Jul 14, 2019
Merged

Move range updating to DirtyRowService and add dependency injection #2311

merged 14 commits into from
Jul 14, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 14, 2019 •
edited
Loading

  • Adds a tslint rule to prevent imports from out, I suspect these imports might be one of the reasons tsserver dies
  • Added more granulate dirty range updating and moved it into DirtyRowService
  • Added vscode-style dependency injection

Part of #1507
Fixes #1996

@jerch 123 left 😉

@Tyriar Tyriar added this to the 4.0.0 milestone Jul 14, 2019
@Tyriar Tyriar self-assigned this Jul 14, 2019
@Tyriar Tyriar changed the title Move range updating to DirtyRowService Move range updating to DirtyRowService and add dependency injection Jul 14, 2019
@Tyriar Tyriar merged commit a94a361 into xtermjs:master Jul 14, 2019
@Tyriar Tyriar deleted the layering3 branch July 14, 2019 15:55
@Tyriar Tyriar mentioned this pull request Nov 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Create a tslint rule to prevent importing from lib
1 participant
@Tyriar