[Pm-18697] Remove SymmetricCryptoKey buffer representation #13599
+114
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## km/refactor-symmetric-keys-2 #13599 +/- ##
=============================================================
Coverage 15.26% 15.26%
=============================================================
Files 28 28
Lines 1946 1946
=============================================================
Hits 297 297
Misses 1649 1649 ☔ View full report in Codecov by Sentry. |
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
quexten
force-pushed
the
km/refactor-symmetric-keys-2
branch
from
284ec3f to
b4226cd
Compare
quexten
changed the title
|
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18697
This is a follow-up PR to:
#13578
#13598
📔 Objective
Moves all users of symmetriccryptokeys inner representation to use the
toEncodedmethod so that we can delegate this to the sdk when the new format is added.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes